Skip to content

Upgrating evergreen hosts to Rhel 8 #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 4, 2022
Merged

Upgrating evergreen hosts to Rhel 8 #1016

merged 3 commits into from
Mar 4, 2022

Conversation

@andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 4, 2022 •
edited
Loading

Proposed changes

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated e2e/E2E-TESTS.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

In #1014 we started using git tag --sort=committerdate which is not available for git version 1.8.3.1, the version
shipped with Red Hat 7 (error).
This PR updates our evergreen tests to use Rhel 8

andreaangiolillo
andreaangiolillo commented Mar 4, 2022
View reviewed changes
build/ci/evergreen.yml
Comment on lines +96 to +101
script: |
set -Eeou pipefail
export GOROOT="${go_root}"
export PATH="./bin:$GOROOT/bin:$PATH"
go tool cover -html=coverage.out -o coverage.html
Copy link
Collaborator Author

@andreaangiolillo andreaangiolillo Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test task was failing https://evergreen.mongodb.com/task/mongocli_master_code_health_unit_test_patch_5db0fa1d7119cbe3dfe2846583efef62ad6b6b12_622216f4c9ec441217444069_22_03_04_13_41_09

@andreaangiolillo andreaangiolillo requested a review from gssbzn March 4, 2022 14:06
@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 4, 2022 14:06
@andreaangiolillo andreaangiolillo requested a review from a team March 4, 2022 14:06
blva
blva approved these changes Mar 4, 2022
View reviewed changes
Copy link
Collaborator

@blva blva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andreaangiolillo andreaangiolillo merged commit ce89412 into master Mar 4, 2022
@andreaangiolillo andreaangiolillo deleted the upgrade_evergreen_hosts_to_rhel8 branch March 4, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blva blva blva approved these changes

@gssbzn gssbzn Awaiting requested review from gssbzn

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaangiolillo @blva